Adding poro howto #1673
Merged
Adding poro howto #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @id = attributes[:id] | ||
| @name = attributes[:name] | ||
| @level = attributes[:level] | ||
| end |
There was a problem hiding this comment.
can you fix the indentation on these lines?
|
hey, can you add a link to your new doc under and then add a changelog entry to give yourself credit? :-) |
|
@NullVoxPopuli can you tell me how to do that? |
trying to get styling correct added changelog entry, link to guide, and fixed indentation
|
yup, I have some instructions here: https://github.com/NullVoxPopuli/git-workflow/blob/master/single-repo/README.md#preparing-your-feature--bug-fix-to-be-merged lemme know if you have any questions |
DrSayre
force-pushed
the
adding_poro_howto
branch
from
d9f0d61 to
05618ea
Compare
|
@NullVoxPopuli let me know if I did it correctly |
|
it looks like you did! |
|
LGTM! thanks, @DrSayre |
|
oh, it looks like I could have squashed. It's after I click merge. oops. |
|
no worries, glad I could help out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Easier to find documentation on using AMS with a PORO
Changes
Adds a guide under how to showing how to create a PORO that can be used with AMS.
Caveats
Related GitHub issues
#1521
Additional helpful information